Configure Growth endpoint with Actions variables#3120
Conversation
Greptile SummaryThis PR moves the
Confidence Score: 4/5Safe to merge if both the The workflow change is straightforward and the intent is clear, but it introduces two hard infrastructure pre-conditions: the
Important Files Changed
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/workflows/publish.yml:51
**Staging environment must exist before next release fires**
Referencing `environment: staging` causes GitHub Actions to immediately fail the job if the `staging` environment does not exist in the repository's Settings → Environments. The PR description documents this pre-condition, but until the environment is provisioned, any published release will hard-fail the `publish-cloud-stage` job — blocking the staging Docker image from being built and pushed.
### Issue 2 of 2
.github/workflows/publish.yml:45
**Silent empty string if repo-level variable is absent**
`vars.VITE_APPWRITE_GROWTH_ENDPOINT` resolves to an empty string — with no error or warning — when the Actions variable has not been created at repository scope. Unlike the previous `secrets.*` approach (same silent-empty behavior), the variable name has changed from `PUBLIC_GROWTH_ENDPOINT` to `VITE_APPWRITE_GROWTH_ENDPOINT`. If the new repo-level variable is not yet provisioned, the production `publish-cloud`, `publish-self-hosted`, and `publish-cloud-no-regions` jobs will all bake an empty `PUBLIC_GROWTH_ENDPOINT` into their Docker images silently. The PR description states the variable "remains" in place, so this is low-risk in practice, but worth verifying before the next release.
Reviews (1): Last reviewed commit: "fix: configure Growth endpoint with Acti..." | Re-trigger Greptile |
Summary
stagingGitHub EnvironmentVITE_APPWRITE_GROWTH_ENDPOINTto resolve to the staging environment override while other images retain the repository-level production valueRepository setup
Before the next release, an administrator must create the
stagingGitHub Environment and configure:The existing repository-level variable remains
https://growth.appwrite.io/v1.Testing
actionlint .github/workflows/publish.ymlgit diff --check