Skip to content

fix: Server return html but not Rendering#3126

Merged
HarshMN2345 merged 5 commits into
appwrite:mainfrom
BretRen:fix/a-tag
Jul 20, 2026
Merged

fix: Server return html but not Rendering#3126
HarshMN2345 merged 5 commits into
appwrite:mainfrom
BretRen:fix/a-tag

Conversation

@BretRen

@BretRen BretRen commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

fix #3125

Test Plan

Runs without bugs.

Related PRs and Issues

#3125

Have you read the Contributing Guidelines on issues?

Yes

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes modal error messages that need to render safe links. The main changes are:

  • Added DOMPurify as a sanitizer dependency.
  • Updated the shared modal error alert to sanitize HTML before rendering it.
  • Preserved allowed links and added link styling inside modal errors.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
src/lib/components/modal.svelte Sanitizes modal error HTML with DOMPurify and keeps allowed error links styled.
package.json Adds DOMPurify and its type package for the modal sanitization change.
bun.lock Updates the lockfile for the new sanitizer dependency.

Reviews (4): Last reviewed commit: "Add 'target' attribute to allowed attrib..." | Re-trigger Greptile

Comment thread src/lib/components/modal.svelte Outdated
Comment thread src/lib/components/modal.svelte
Comment thread src/lib/components/modal.svelte
Comment thread src/lib/components/modal.svelte
@HarshMN2345
HarshMN2345 merged commit 26df26a into appwrite:main Jul 20, 2026
3 checks passed
@BretRen
BretRen deleted the fix/a-tag branch July 20, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the "Invite member" pop-up, an <a> tag appears if SMTP has not been enabled on the server.

2 participants