feat: Web SDK update for version 25.1.0#169
Conversation
Greptile SummaryThis PR bumps the Web SDK to version 25.1.0 with three new OAuth providers (Fusionauth, Keycloak, Kick), a new
Confidence Score: 4/5The PR is safe to merge; the only notable concern is the The src/client.ts — specifically the interaction between the new Important Files Changed
Reviews (1): Last reviewed commit: "chore: update Web SDK to 25.1.0" | Re-trigger Greptile |
| setCookie(value: string): this { | ||
| this.headers['Cookie'] = value; | ||
| this.config.cookie = value; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
credentials: 'include' not suppressed when Cookie is set
When setCookie() is called without also calling setDevKey(), prepareRequest still applies credentials: 'include' because the guard only checks for X-Appwrite-Dev-Key. In browser environments the Cookie header is a forbidden header and will be silently dropped by the Fetch API, meaning the method has no effect there. In Node.js environments the explicit Cookie header works correctly, but if the runtime has a non-empty undici cookie jar, those cookies could be included alongside the manually forwarded ones — which is the opposite of the isolation this method implies. Consider extending the credentials guard to also suppress the flag when a Cookie header is present.
|
Closing — changes not substantial enough to warrant a release. |
This PR contains updates to the SDK for version 25.1.0.
What's Changed
setCookie()method toClientfor forwarding incomingCookieheaders in server-side runtimesFusionauth,Keycloak, andKickOAuth providers toOAuthProviderenumX-Appwrite-Response-Formatheader to1.9.4