feat: support concurrent chunk uploads#174
Conversation
Greptile SummaryThis PR rewrites the chunked upload path in
Confidence Score: 5/5The concurrent upload logic is structurally sound; the two new observations are cosmetic or edge-case concerns that do not affect normal operation. The core concurrency change is correct: first chunk is uploaded sequentially to get the upload ID, remaining chunks are dispatched with an in-flight cap, shared counters are safe under JS's single-threaded model, and failure propagation is handled cleanly. The two findings are a type-widening regression in ping() and a defensive fallback that only matters if the server returns an unexpected response shape. src/client.ts — the isUploadComplete predicate and finalResponse ?? lastResponse fallback are worth a second look to confirm they match the server's actual response shape for assembled files. Important Files Changed
Reviews (2): Last reviewed commit: "feat: support concurrent chunk uploads" | Re-trigger Greptile |
|
Note for reviewers: the normal cloud |
|
@greptile-apps please review this PR again. |
This PR updates the Web SDK to support concurrent chunk uploads.