fix: avoid premature tmp cleanup for multi-container scans#2899
Open
mdusher wants to merge 1 commit intoaquasecurity:mainfrom
Open
fix: avoid premature tmp cleanup for multi-container scans#2899mdusher wants to merge 1 commit intoaquasecurity:mainfrom
mdusher wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running trivy-operator in ClientServer mode, ScanJobs will fail due to the temp directory being cleaned up by another container's scan. This causes VulnerabilityReports to either not be generated, or delayed until you are lucky enough for all containers to complete their image scans before a cleanup occurs.
This pull request is based on the patch @daanschipper mentioned in the original issue (daanschipper@1749113) to use per-container tmp volumes when running scans to avoid the premature temp file cleanup.
Related issues
Checklist