fix(vuln): save package-specific severity before severity selection#10300
Open
DmitriyLewen wants to merge 17 commits intoaquasecurity:mainfrom
Open
fix(vuln): save package-specific severity before severity selection#10300DmitriyLewen wants to merge 17 commits intoaquasecurity:mainfrom
DmitriyLewen wants to merge 17 commits intoaquasecurity:mainfrom
Conversation
- check redhat source for redhat-oval
- use redhat as severity source - overwrite datasource
Contributor
Author
|
Reopened from #9192 after recreating the fork. |
Contributor
|
This PR is stale because it has been labeled with inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored vulnerability severity processing logic to fix package-specific severity handling. The changes move the package-specific severity processing earlier in the flow and ensure vendor severities are properly stored before the main severity selection logic runs.
Found mistakes
RedHatvulnerabilities don't haveDataSourceand use incorrectSeveritySource(redhatinstead ofredhat-oval.This PR fixes these mistakes, updates tests and improves severity selection logic for
redhat.Reason
The original code had a logical issue where package-specific severity handling was interfering with the main severity selection process. When a vulnerability had a SeveritySource set (indicating package-specific severity), the code was overriding the selected severity and source, but this happened after the main severity selection logic had already run.
Benefits
Examples:
Before:
After:
Related issues
--vuln-severity-sourcedoesn't work for package-specific severity (e.g. Debian) #9191Related PRs
--vuln-severity-sourceflag #8269Checklist