feat(spdx): add SHA-512 checksum support to SPDX unmarshaler#10363
Open
Mananshah237 wants to merge 1 commit intoaquasecurity:mainfrom
Open
feat(spdx): add SHA-512 checksum support to SPDX unmarshaler#10363Mananshah237 wants to merge 1 commit intoaquasecurity:mainfrom
Mananshah237 wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
- Add unmarshalChecksums() to convert spdx.Checksum to digest.Digest - Update file parsing to include checksums from spdx.Files - Add fallback: if no files exist, store PackageChecksums as digest-only File - Add test data and unmarshal test case for SHA-512 package checksum Closes aquasecurity#9094 Ref aquasecurity#9130
Contributor
|
Hi @Mananshah237 ! Thank you for your contribution. How does your PR differ from the one opened earlier? #9130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SHA-512 checksum support to the SPDX unmarshaler, completing the
full round-trip support (marshal + unmarshal) for SHA-512 in SPDX.
Changes
unmarshalChecksums()to convert[]spdx.Checksumto[]digest.Digestspdx.FilesPackageChecksumsis non-empty,store digests as a digest-only
core.Fileentrytestdata/happy/package-hashes.json) and unmarshal test caseNote
go test ./pkg/sbom/spdx/...fails with a pre-existing Go 1.26encoding/json/jsontextbuild constraint issue unrelated to these changes.go build ./pkg/sbom/spdx/...passes cleanly.Closes #9094
Ref #9130