Support --open on Linux via xdg-open/open#7
Open
alcarraz wants to merge 1 commit into
Open
Conversation
--open only worked on macOS since it was gated behind a Darwin check. Now it also opens the PDF on Linux using xdg-open, falling back to open if present. --yoink stays macOS-only since Yoink has no Linux equivalent. If neither open command is found, a warning is only printed with --info to keep default behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--opencurrently only opens the generated PDF on macOS (open), silently doing nothing elsewherexdg-open, falls back toopenif present--yoinkis left untouched (macOS-only, no Linux equivalent)opennorxdg-openis found, a warning is only printed with--info, to keep default behavior unchanged when nothing can be openedTest plan
bash -n bin/memopasses./bin/memo --open memomemo.mdon Linux successfully opens the PDF viaxdg-openopenpath and--yoinkbehavior unchanged