Fix sized delete unused parameter warnings#626
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
|
Memory usage change @ f6d8cca
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Compiling the AVR core with
-Wunused-parameterreports warnings for thesizeparameter in the C++14 sizedoperator deleteoverloads.Root cause
The sized delete overloads only need the
sizeparameter for overload selection; the implementation delegates to the unsized delete overloads and intentionally does not use the value.Solution
Mark the two sized delete
sizeparameters with[[gnu::unused]], matching the explicit unused-parameter style already preferred for this file's warning fixes.Fixes #623.
Tests
g++ -std=gnu++14 -Wall -Wextra -c cores/arduino/new.cpp -Icores/arduino -o %TEMP%/arduino-new-after.oand verified the reportedunused parameter 'size'warnings are gonegit diff --check