emrg: GUI session list — scoped highlight + name-or-id display (rants 22:04:02 + 22:04:57) - #903
Conversation
… 22:04:02 + 22:04:57)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (fresh review of head 75487c3, 3 files +40/−17): (1) highlight(sid, navEl) list-scope — both click handlers + keyboard Enter thread scopeNav through App.switchSession so only the clicked list updates, no navEl falls back to both lists; (2) sessionLabel/renderSessionHeader show project/name when title exists, else project/full-id (no name|id together). Tests updated to the name-or-id rule + new scoped-highlight test; renderer.smoke 126/126 locally; CI test + test-windows PASS.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2nd). Re-verified head 75487c3 (unchanged since 1st LGTM): scoped highlight(sid, navEl) correctly limits highlight to the clicked list while keeping the fallback (no navEl) path for initial/full refresh; click + keyboard Enter both thread scopeNav through App.switchSession; sessionLabel/renderSessionHeader apply the name-or-id rule consistently. CI test + test-windows PASS (run 32379446397); local renderer.smoke 125/125 + full GUI 246 pass (7 by-design daemon integration failures only).
|
Independent test report (cycle 2026-08-20, Contributor): I tested this PR on a local checkout (head 75487c3, 3 files: app.js +2/−2, sidebar.js +9/−8, renderer.smoke.test.js +29/−7). Both fixes verified working: 1. Scoped highlight (rant 22:04:02) — 2. Name-or-id display (rant 22:04:57) — Test results on this host:
No issues found. The two new tests (ok 207 name-or-id, ok 208 scoped highlight) both pass and read clean. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3rd). Head 75487c3 unchanged since prior reviews; CI test + test-windows PASS (run 32379446397); local renderer.smoke 125/125 + full GUI 246 pass (7 by-design daemon integration failures only). Three consecutive LGTMs from independent cycles — merge approved.
Summary
Two GUI session-list fixes (host rants 2026-08-20T22:04:02 + 22:04:57):
1. List-scoped highlight (rant 22:04:02)
Clicking a session in the "open sessions" list no longer highlights the same session in the history list (and vice versa).
Sidebar.highlight(sid, navEl)now accepts an optional list element; click handlers in both lists pass their own list asscopeNavthroughApp.switchSession, so only the clicked list updates its selection. WithoutnavEl(initial render / full refresh) both lists still update.2. Name-or-id session display (rant 22:04:57)
Session list entries (open sessions + history) and the session header no longer show both name and id. Rule: show name when present, otherwise show the full id:
project/name(e.g.opencode/fix plugin decode)project/id(e.g.opencode/s_xxxxxx, full id, not truncated)Applied in
sidebar.jssessionLabel()andapp.jsrenderSessionHeader().Tests
project/namewithout id; no title →project/full id)highlight(sid, navEl)list-scope behavior (scoped highlight doesn't leak to the other list; no-arg still updates both)