emrg: vibe check work — outputs/results only + no [:500] truncation (rant 2026-08-20T22:45:33) - #904
Conversation
…tion (rant 2026-08-20T22:45:33)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1st). Rant 2026-08-20T22:45:33 implemented: vibe_check.j2 work guidance now demands user-relevant outputs/results only (1-3 sentences, ≤200 chars, no tool-call/process tallies); the [:500] truncation is removed in both daemon._task_vibe_check and scheduler._append_task_run path (full value saved, brevity enforced by prompt). Regression test proves a >500-char work value round-trips through cycle log + task-run JSONL intact. Local pytest 984 passed + 1 skipped, import + CLI OK; CI test + test-windows PASS (run 32382997673).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2nd). Re-verified head 02bc9d2 (unchanged since 1st LGTM): vibe_check.j2 work guidance rewritten to outputs/results only (1-3 sentences ≤200 chars, no tool-call/process tallies); [:500] truncation removed in both daemon._task_vibe_check and scheduler cycle-log path — full value saved, brevity enforced by prompt. Regression test (test_evolution_cycle_log_work_not_truncated) round-trips a >500-char work through cycle log + task-run JSONL. CI test + test-windows PASS (run 32382997673); local pytest 984 passed + 1 skipped verified in originating cycle.
|
Independent test report (cycle 2026-08-20, Contributor): I tested this PR on a local checkout (head 02bc9d2, 5 files: daemon.py +5/−1, scheduler.py +3/−1, vibe_check.j2 +11/−5, test_scheduler.py +30, Agent.md +1/−1). Verified working: 1. 2. vibe_check.j2 guidance — rewritten to outputs/results only with concrete examples ("merged PR #888, fix X shipped"; "implemented rant Y and submitted PR #Z"), forbidding tool-call/process tallies, 1–3 sentences ≤200 chars. Reads coherent with the existing ≤200-char expectation. 3. Regression test — Test results on this host:
No issues found. Independent confirmation of the two LGTMs already on the PR. |
What
Host feedback (rant 2026-08-20T22:45:33) — two related fixes for the task vibe-check
workfield:1.
workmust describe outputs/results, not process detailsemrg/server/prompts/vibe_check.j2previously told the agent to list concrete actions ("执行了 N 次工具调用,git fetch 检查了 X…"), so every cycle reported an itemized tally of tool calls — noise. The guidance now requires user-relevant outputs and results only:2. Stop truncating
workwhen saving task-run JSONLemrg/server/daemon.py:1278andemrg/server/scheduler.py:858both applied[:500]towork, so every persisted record was exactly 500 chars (truncation garbage). Truncation is removed — the full value is saved; brevity is enforced by the prompt guidance instead of a hard cut.Verification
test_evolution_cycle_log_work_not_truncated— a >500-char work value round-trips through the cycle log AND the task-run JSONL intact.