Update radxa-cubie-a5e.csc with current kernel for build#9874
Conversation
Add "current" kernel (for build?)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughKERNEL_TARGET in the Radxa Cubie A5E board config is changed from ChangesKernel Target Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/boards/radxa-cubie-a5e.csc`:
- Line 10: KERNEL_TARGET is set to "current,edge" but the radxa-aic8800 DKMS
install is conditionally skipped in
post_install_kernel_debs__install_aic8800_dkms_package()
(extensions/radxa-aic8800.sh) when linux-version compare "${KERNEL_MAJOR_MINOR}"
ge 6.20, which can leave AIC8800 WiFi/BT missing for one of the kernel targets;
ensure both kernel targets produce images with working AIC8800 by either (a)
adjusting the condition in
post_install_kernel_debs__install_aic8800_dkms_package() to install DKMS when
AIC8800_TYPE="sdio" regardless of KERNEL_MAJOR_MINOR, or (b) adding shore-up
packaging or in-tree module fallback for the affected kernel target, and then
run at least one full build and basic WiFi+Bluetooth functional check for both
KERNEL_TARGET values to confirm the radxa-aic8800 extension and
AIC8800_TYPE="sdio" result in usable firmware/modules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: de2092f2-b55a-4086-b20f-c0f29836ca02
📒 Files selected for processing (1)
config/boards/radxa-cubie-a5e.csc
- Add KERNEL_TEST_TARGET
|
In the latest generation of "Armbian Community" images, only the edge image (7.0.x) is available. |
Description
( generated by Copilot and also the "Title")
This pull request updates the kernel target configuration for the
radxa-cubie-a5eboard to support both thecurrentandedgekernel targets instead of justedge.KERNEL_TARGETinconfig/boards/radxa-cubie-a5e.cscto include bothcurrentandedgekernels, allowing the board to be built with either kernel version.Add "current" kernel (for build?)Summary by CodeRabbit