Skip to content

Update ES CAE with EHA/3482/2007 activity keys and BOE reference#493

Open
quiqueporta wants to merge 1 commit intoarthurdejong:masterfrom
quiqueporta:update-es-cae-boe-reference
Open

Update ES CAE with EHA/3482/2007 activity keys and BOE reference#493
quiqueporta wants to merge 1 commit intoarthurdejong:masterfrom
quiqueporta:update-es-cae-boe-reference

Conversation

@quiqueporta
Copy link
Copy Markdown
Contributor

Update Spanish CAE module to align with Orden EHA/3482/2007: refresh the BOE link, add the F7 and GP activity keys, fix some descriptions and the Bizkaia spelling, plus doctest coverage for the new keys.

@quiqueporta
Copy link
Copy Markdown
Contributor Author

Note on the failing mypy job

The Test / tox_job (mypy) failure is not caused by this PR. I reproduced it locally and the exact same 11 errors are present on master.

The root cause is the recent release of mypy 2.0.0, which tox.ini pulls unpinned. Two breaking changes affect this repo:

  1. python_version = 3.9 in setup.cfg is no longer accepted (mypy 2.0 requires 3.10+), which also makes the first tox command (mypy -p stdnum --python-version 3.9) fail outright.
  2. Stricter var-annotated / no-any-return checks now flag the dynamic module-loading patterns in stdnum/iban.py, stdnum/vatin.py, stdnum/numdb.py, stdnum/util.py, stdnum/eu/vat.py and stdnum/eu/excise.py (e.g. country_modules, _open_databases, _soap_clients).

Possible fixes (out of scope for this PR, happy to send a separate one if useful):

  • Pin mypy<2.0 in tox.ini as a short-term fix.
  • Bump the declared python_version to 3.10 in setup.cfg and add explicit annotations to the dynamic-loading dicts.

This PR only touches stdnum/es/cae.py and its doctest, so it doesn't introduce any of these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant