Skip to content

Fix PDS Moover backups (Authorization header + CORS) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jphastings wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PDS Moover backups (Authorization header + CORS) #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6266817
fix(pds): allow Authorization header in CORS preflight
jphastings Jun 1, 2026
4cd16af
fix(pds): reflect requested CORS headers instead of a fixed allowlist
jphastings Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/cors-authorization-header.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@getcirrus/pds": patch
---

Be explicit with CORS headers so browser-based authenticated XRPC calls work (particularly PDS Moover).

The CORS middleware advertised `Access-Control-Allow-Headers: *`, but this didn't cover the `Authorization` header needed by tools like PDS Moover. As a result, authed cross-origin requests from web clients (eg. PDS Moover's `com.pdsmoover.backup.getRepoStatus`) were blocked at preflight. This is now resolved; all headers are reflected back, just like the Bluesky implementation.
7 changes: 6 additions & 1 deletion packages/pds/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,12 @@ app.use(
cors({
origin: "*",
allowMethods: ["GET", "POST", "PUT", "DELETE", "OPTIONS"],
allowHeaders: ["*"],
// Omit allowHeaders: Hono reflects the browser's
// Access-Control-Request-Headers back, matching the reference
// atproto PDS (`cors({ maxAge })`). This allows Authorization
// (a `*` wildcard wouldn't), DPoP, atproto-proxy,
// atproto-accept-labelers, accept-language, x-bsky-topics and
// any future header automatically.
exposeHeaders: ["Content-Type"],
maxAge: 86400,
}),
Expand Down