Add ways scale framebuffer preserving aspect ratio#55
Open
geloescht wants to merge 4 commits into
Open
Conversation
…ing size adjustments (but not input transformation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the fillMode property to the FBController component. It works similar to the property of the same name in the standard QTQuick Image component, but does not support tiling.
It also adds the framebufferSize property, allowing QML to know the width and height of the allocated frambuffer.
One open question is, whether the allowScaling property and its behaviour needs to be preserved for backwards compatibility reasons, or if
fillMode: FBController.Padis a good enough replacement. Right now it is a bit of a mix.PS: geloescht:micropaint has an additional example that I used to help with the development of this feature.