Skip to content

FIX: clear stale _ex before each execute_stream call#751

Merged
msdemlei merged 1 commit into
astropy:mainfrom
stvoutsin:fix_dal_query_exc
May 18, 2026
Merged

FIX: clear stale _ex before each execute_stream call#751
msdemlei merged 1 commit into
astropy:mainfrom
stvoutsin:fix_dal_query_exc

Conversation

@stvoutsin
Copy link
Copy Markdown
Contributor

Description

_ex was never cleared between execute_stream calls, so there was the potential that a stale HTTP error from a previous failed request could mask VOTable parse errors on a later successful one.

Fix

Reset self._ex = None at the start of execute_stream

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.57%. Comparing base (f14fabb) to head (b3910bf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   79.54%   79.57%   +0.02%     
==========================================
  Files          91       91              
  Lines       10293    10294       +1     
==========================================
+ Hits         8188     8191       +3     
+ Misses       2105     2103       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stvoutsin stvoutsin force-pushed the fix_dal_query_exc branch from b836762 to 060a803 Compare May 16, 2026 01:53
@stvoutsin stvoutsin force-pushed the fix_dal_query_exc branch from 060a803 to b3910bf Compare May 16, 2026 01:54
Copy link
Copy Markdown
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msdemlei msdemlei merged commit 5231fb0 into astropy:main May 18, 2026
13 checks passed
@bsipocz bsipocz added this to the v1.8.2 milestone May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants