docs(README): drop dead VAO website link, point at Wayback snapshot (#748)#752
Merged
Merged
Conversation
…stropy#748) www.usvao.org now redirects to a domain-parking page (the project website was decommissioned). The README's inline reference '(VAO, www.usvao.org)' takes users from a Python library README to a sales page that fingerprints visitors, which is the opposite of useful. Drop the inline URL from the parenthetical and add a one-line note that points at the 2019-01-06 Wayback snapshot so the historical project page stays reachable for anyone tracing the package's origins.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 91 91
Lines 10294 10294
=======================================
Hits 8191 8191
Misses 2103 2103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for the quick turnaround! If the Wayback link isn't quite the shape you want long-term, happy to push a follow-up that either drops the parenthetical entirely or replaces it with a current IVOA/VAO reference. Just let me know. |
Member
|
I'm sorry for not reacting to the PR sooner, but I'm afraid I'll edit out the link and wayback machine from the readme. The link already redirects to navo, and it's not exactly the same thing so I think it will be cleaner to just do a cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #748.
www.usvao.orgwas the original VAO project website that funded the early development of PyVO. The domain has since lapsed and now resolves to a parking page that fingerprints visitors and offers the domain for sale, which is what the issue reports.Drop the inline URL from the parenthetical and add a one-line note pointing at the 2019-01-06 Wayback snapshot so the historical project page stays reachable for anyone tracing the package's origins. The surrounding context is preserved as-is.
Change Type