Update tree-sitter-python + Add missing tree-sitter scopes#325
Conversation
|
@sadick254 @darangi Please take a look. |
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
aminya
changed the title
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>
|
As a heads-up, #313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now. |
Thanks for the PR. I only need a few of these commits in my PR so I can close many things here and there. If you can rebase after me, that would be great. cc: @sadick254 |
|
What’s the status on this? Because once this is merged, kite should also merge the “remove workaround” (a.k.a. Stop it nagging me). Then I get to enjoy performing |
atom 😎
|
This is ready to go. We are awaiting one of the maintainers to merge this. |
|
@jeff-hykin (the reviewer) |
|
@ThatXliner Not sure why I'm reviewer, but I added a review 😁 |
|
Thanks @aminya , We will look into this |
|
@aminya could you resolve this conflict so I merge this in? Thanks for your contributions 🙇🏾 |
|
Thank you! The conflict was only the deleted travis file. |
| '^(BaseException|Exception|TypeError|StopAsyncIteration|StopIteration|ImportError|ModuleNotFoundError|OSError|ConnectionError|BrokenPipeError|ConnectionAbortedError|ConnectionRefusedError|ConnectionResetError|BlockingIOError|ChildProcessError|FileExistsError|FileNotFoundError|IsADirectoryError|NotADirectoryError|InterruptedError|PermissionError|ProcessLookupError|TimeoutError|EOFError|RuntimeError|RecursionError|NotImplementedError|NameError|UnboundLocalError|AttributeError|SyntaxError|IndentationError|TabError|LookupError|IndexError|KeyError|ValueError|UnicodeError|UnicodeEncodeError|UnicodeDecodeError|UnicodeTranslateError|AssertionError|ArithmeticError|FloatingPointError|OverflowError|ZeroDivisionError|SystemError|ReferenceError|BufferError|MemoryError|Warning|UserWarning|DeprecationWarning|PendingDeprecationWarning|SyntaxWarning|RuntimeWarning|FutureWarning|ImportWarning|UnicodeWarning|BytesWarning|ResourceWarning|GeneratorExit|SystemExit|KeyboardInterrupt)$' | ||
| scopes: 'support.type.exception'} | ||
| scopes: 'support.type.exception'}, | ||
| {match: '^(self)', scopes: 'entity.name.variable.self'} |
There was a problem hiding this comment.
This needs ^(self)\\b otherwise it'll match the self in selfserve and other things
| 'default_parameter > identifier:nth-child(0)': 'variable.parameter.function' | ||
| 'keyword_argument > identifier:nth-child(0)': 'variable.parameter.function' | ||
| 'lambda_parameters > identifier': 'variable.parameter.function' | ||
| 'typed_parameter > identifier': 'variable.parameter.function' |
There was a problem hiding this comment.
Not sure why .function is on there (aren't parameters always part of a function?)
|
(😬 I was cleaning out my notifications and realized I commented "but I added a review" without clicking "submit" on my review) |
|
Thanks for the review. Do you want to make a PR to fix these? |
|
The first comment should probably be a PR, although that edgecase bug I'm describing probably happens other places too. Its a really common bug with a very very small edgecase. The other comment was just clarification. |
6 participants
Description of the Change
This updates tree-sitter python dependency.
Benefits
Bug fixes: tree-sitter/tree-sitter-python@v0.15.1...v0.17.0
Applicable Issues
Solves some of the open issues regarding syntax highlighting.
Fixes #324
Fixes #134
Fixes #273
Fixes #312
Allows removing the Kite's workaround for tree-sitter:
https://github.com/kiteco/atom-plugin/pull/704