refactor: Address post-V4-merge review comments and add missing tests#1017
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates repository configuration and Android compatibility documentation, dispatches Auth Tab launches on the main thread, and strengthens credential-manager concurrency, cleanup, encryption-failure, and SSO deserialization tests. ChangesSDK maintenance
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up cleanup after merging
v4_developmentintomain(#1011), addressing CodeRabbit review comments that were worth acting on.AuthTabIntent.launch(...)on the main thread viathreadSwitcher.mainThread(...), matching the existing failure-callback dispatch pattern (ActivityResultLauncher.launch()must run on the main thread).org.mockito.Mockito.verifystatic import that clashed withorg.mockito.kotlin.verify, resolving overload-resolution ambiguity across allverify(...)call sites. Added tests forclearAll()DPoP key-pair deletion (including the deletion-failure path), executor lifecycle cleanup intearDown(), and a crypto-exception stub case.expires_in).v4_developmenttrigger fromtest.yml, ignoredplans/anddocs/.Test plan
./gradlew :auth0:compileDebugUnitTestKotlin— BUILD SUCCESSFUL./gradlew :auth0:testDebugUnitTest— full unit suite greenSummary by CodeRabbit
Bug Fixes
Documentation