chore: remove unused imports - #794
Open
Zichen1028 wants to merge 2 commits into
Open
Conversation
Contributor
|
Hi @Zichen1028, Thank you for your contribution! Could you please sign your commits when you have a chance? In the meantime, I'll go ahead and review the PR. Thanks! |
Zichen1028
force-pushed
the
chore/remove-unused-objectreader-import
branch
from
August 3, 2026 13:43
65a4e1e to
a486c76
Compare
Author
Hi @tanya732 , Thank you for pointing this out! This is actually my first public contribution, so I really appreciate your guidance. I’ve now signed my commits and updated the PR accordingly. Thanks again for your help, and I appreciate you taking the time to review my contribution! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed #793
From #620 (
9024318, Jan 2023) — this PR replaced a storedObjectReaderfield with a freshObjectCodecobtained from theJsonParserat deserialize time, removing every usage ofObjectReader, but left the import behind in two places:lib/src/main/java/com/auth0/jwt/impl/PayloadDeserializer.java(line 12):import com.fasterxml.jackson.databind.ObjectReader;lib/src/test/java/com/auth0/jwt/impl/PayloadImplTest.java(line 6):import com.fasterxml.jackson.databind.ObjectReader;From
d8fe9a2(Jun 2023) — this commit removed anassertThat(values, is(IsEmptyCollection.empty()))assertion but left the import:lib/src/test/java/com/auth0/jwt/impl/PayloadDeserializerTest.java(line 14):import org.hamcrest.collection.IsEmptyCollection;Two more, found via a repo-wide scan for the same pattern:
lib/src/test/java/com/auth0/jwt/JWTTest.java(line 15):import java.time.Duration;lib/src/test/java/com/auth0/jwt/interfaces/VerificationTest.java(line 15):import static org.junit.Assert.assertThrows;Validation
./gradlew buildChecklist