feat: replace ref-based messages with component-based message bubbles#545
Open
avoidwork wants to merge 12 commits into
Open
feat: replace ref-based messages with component-based message bubbles#545avoidwork wants to merge 12 commits into
avoidwork wants to merge 12 commits into
Conversation
- Extract MessageBubble component with internal state management - Create MessageList component for managing bubble instances - Simplify app.js and conversationPanel.js to use new component API
- Section 1: 6/8 tasks complete (1.6, 1.8 pending) - Section 2: 10/10 tasks complete - Section 3: 5/5 tasks complete - Section 4: 5/10 tasks complete (4.6-4.10 pending) - Sections 5-6: not started
- Replace Date.now() + Math.random() with crypto.randomUUID() - Ensures stable, globally unique IDs for each MessageBubble
- Add formatMessage, isStreamingMessage, countMessageLines, getToolCallLines - Task 1.6 complete
- Add formatTime, getRoleColors, getBubbleStyle, renderMessages to conversationPanel.js - Remove unused imports from messageBubble.js - Mark tasks 13.1-13.4 as complete (tests, lint, coverage, startup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the ref-based message array architecture in the TUI with a component-based system where each message is a standalone MessageBubble component managing its own state. This eliminates the need for messagesRef, forceRender, and array spreading that fights React's rendering model.
Type of Change
Testing
Coverage
Checklist
npm run lintpassesRelated Issues
Fixes #541