chore: add patch-package postinstall for node24 inquirer prompts#14959
Draft
sarayev wants to merge 3 commits into
Draft
chore: add patch-package postinstall for node24 inquirer prompts#14959sarayev wants to merge 3 commits into
sarayev wants to merge 3 commits into
Conversation
Adds patch-package as a dependency and a postinstall hook to apply local patches that fix inquirer/base-ui interactive prompt behavior under Node 24. The patch file patches/inquirer+7.3.3.patch is also included. Also updates scripts/cloud-pr.sh to add a CLOUD_PR_SKIP_MWINIT escape hatch and drop the --debug-session-enabled flag, which AWS CLI v1 does not support. --- Prompt: Move stashed node24 inquirer/base-ui patch-package WIP to a new branch, then commit and create a draft PR.
Adds the yarn.lock entries for patch-package and its transitive dependencies (ci-info, find-yarn-workspace-root, tmp) that were missing after patch-package was added to the root devDependencies. Without this, CodeBuild's immutable install fails with YN0028. --- Prompt: Fix the e2e build_linux YN0028 lockfile failure by regenerating and committing yarn.lock.
Runs yarn dedupe to satisfy the verify_yarn_lock CI check after adding patch-package. Deduplicates ci-info and tmp to their highest resolved versions. No product code changes. --- Prompt: Fix the verify_yarn_lock CI failure by running yarn dedupe and committing yarn.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds
patch-packageas a dev dependency and appends it to thepostinstallhook so thatpatches/inquirer+7.3.3.patchis applied automatically afteryarn install. This fixes interactive prompt rendering (inquirer / base-ui) under Node 24.Also updates
scripts/cloud-pr.sh:CLOUD_PR_SKIP_MWINITescape hatch to skipmwinitwhen already authenticated or running non-interactively.--debug-session-enabledflag from theaws codebuild start-build-batchcall; AWS CLI v1 does not support this flag.Issue #, if available
N/A
Description of how you validated changes
Manually verified
yarn installapplies the patch and prompts work under Node 24.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.