fix(security): bump esbuild to >=0.28.1 to clear GHSA-gv7w-rqvm-qjhr (high) and GHSA-g7r4-m6w7-qqqr#334
Merged
Merged
Conversation
…and GHSA-g7r4-m6w7-qqqr (#333) esbuild 0.27.7 is affected by GHSA-gv7w-rqvm-qjhr (high, CVSS 8.1) and GHSA-g7r4-m6w7-qqqr (low, CVSS 2.5), failing the OSV dependency scan on every PR. Bump the direct devDependency in cdk/package.json and add a root resolution so the transitive copy pulled in by vite (docs workspace) is also lifted to 0.28.1. Closes #333
Contributor
Author
|
All required checks pass, including the previously failing Secrets, deps, and workflow scan (OSV) job. Note on |
krokoko
approved these changes
Jun 12, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
5 tasks
This was referenced Jun 12, 2026
Closed
krokoko
added a commit
to mayakost/sample-autonomous-cloud-coding-agents
that referenced
this pull request
Jun 12, 2026
…aws-samples#335) Merge-queue runs of security-pr.yml left GITLEAKS_RANGE empty, which triggered a full-history gitleaks scan and failed on secrets living on other branches — ejecting otherwise-green PRs (e.g. aws-samples#334) from the queue. Use merge_group.base_sha..head_sha for queued merges and HEAD for manual dispatch instead of scanning all reachable refs. Co-authored-by: bgagent <bgagent@noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #333. Fixes Dependabot alert #71.
The OSV dependency scan has been failing on PRs (e.g. run 27441452583) because
esbuild@0.27.7inyarn.lockis affected by:NPM_CONFIG_REGISTRYBoth are patched in esbuild 0.28.1.
Changes
cdk/package.json— bump the direct devDependencyesbuildfrom^0.27.4to^0.28.1package.json(root) — add"esbuild": "^0.28.1"toresolutions, becausevite(pulled in by thedocsworkspace via Astro) declaresesbuild ^0.27.0; without the resolution the lockfile keeps a second, still-vulnerable 0.27.x copyyarn.lock— regenerated; allesbuildranges now resolve to a single0.28.1entry (diff is esbuild/@esbuild platform packages only)Verification
mise run security:deps(osv-scanner): No issues foundmise //cdk:compile+mise //cdk:test: 111 suites / 2011 tests passed (esbuild bundling of all Lambda assets works on 0.28.1)mise //cli:buildandmise //docs:build: passedmise //cdk:synthfails locally only due to missingec2:DescribeAvailabilityZonespermission on my current AWS credentials (environment issue, unrelated to this change)Dependabot alert #71 should auto-resolve once this merges.