refactor(project): move build behind a project backend - #2055
Merged
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
This was referenced Aug 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2055 +/- ##
=========================================
Coverage 97.14% 97.14%
=========================================
Files 382 383 +1
Lines 22884 22905 +21
=========================================
+ Hits 22231 22252 +21
Misses 653 653 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
agentcore-harness-reviewing
notgitika
marked this pull request as ready for review
August 20, 2026 04:08
notgitika
marked this pull request as draft
August 20, 2026 04:19
notgitika
marked this pull request as ready for review
August 20, 2026 04:24
Hweinstock
approved these changes
Aug 20, 2026
| checkTool?: typeof requireTool; | ||
| }; | ||
|
|
||
| /** Builds projects through the CDK app scaffolded by `agentcore project create`. */ |
Contributor
There was a problem hiding this comment.
this would also be deploying eventually too right? (no need to change anything, just want to make sure I understand the vision)
| @@ -229,47 +240,17 @@ export class FsProjectManager implements ProjectManager { | |||
| } | |||
|
|
|||
| public async *build(project: Project): AsyncGenerator<ProjectEvent, void> { | |||
Contributor
There was a problem hiding this comment.
nice, I really like how clean this is now!
tejaskash
approved these changes
Aug 20, 2026
| `Run 'cd ${cdkDir} && npm install'.`, | ||
| ); | ||
| } | ||
| await this.checkTool("npm", "Install Node.js: https://nodejs.org/"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectBackendboundary selected bymanagedByCdkBackendStack
This is PR 1 of 4 decomposing #2001. Review and merge bottom-up.
typecheck, lint, format, test all pass