[DO NOT MERGE] Feat/harness implementation#909
Closed
tejaskash wants to merge 84 commits into
Closed
Conversation
GITHUB_TOKEN lacks the 'workflows' permission, so pushing workflow file changes from the public repo causes the sync to fail. Use --no-commit --no-ff and restore .github/workflows/ from HEAD before committing, in both the clean merge and conflict paths.
`@aws/agentcore-cdk@0.1.0-alpha.20` has not been published to npm (highest published is alpha.19), so `agentcore create` fails during the vended project's `npm install` step with ETARGET. This breaks E2E tests and any real `create` invocation. Revert until alpha.20 is published. Constraint: alpha.20 is not published on npm Rejected: Keep alpha.20 and publish CDK first | cross-repo coordination required, blocks E2E now Confidence: high Scope-risk: narrow
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
jesseturner21
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
- Update 3 asset snapshots (file listing, cdk/bin/cdk.ts, cdk/lib/cdk-stack.ts) to match current harness-implementation branch content - Fix useDevDeploy test: when skip=true, isComplete is correctly true (skipped means done), not false as the test previously asserted
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
notgitika
temporarily deployed
to
npm-publish-approval
GitHub Actions
Inactive
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.