[v2] Fix non-ASCII escaping in cloudformation package#10380
Open
Zelys-DFKH wants to merge 1 commit into
Open
Conversation
PyYAML defaults to allow_unicode=True, which writes emoji and other non-ASCII characters as raw UTF-8 bytes. CloudFormation displays these as '?' in the console and get-template output. Fixes aws#10185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloudformation packagestarted writing emoji and other non-ASCII characters as raw UTF-8 bytes in output templates in v2.34.13, whenyamlhelper.pyswitched from ruamel.yaml to PyYAML (PR #10164). PyYAML defaults toallow_unicode=True, which writes characters like 🚨 directly rather than as YAML unicode escapes like\U0001F6A8. CloudFormation displays these raw bytes as?in the console and inget-templateoutput.The fix is
allow_unicode=Falseon theyaml.dump()call. This restores the pre-regression behavior with no other changes to serialization.The regression test verifies that emoji characters are serialized as YAML escape sequences rather than raw bytes, and that the escaped output round-trips correctly through
yaml_parse.Fixes #10185
Credit: @rkamach-smtc for the reproduction steps in #10185, and @RyanFitzSimmonsAK for confirming the regression on EC2.
This change was generated with AI assistance and reviewed by me.