fix: parse bytes for callback operations#59
Merged
Conversation
2 tasks
yaythomas
requested changes
Oct 16, 2025
6603748 to
c128fe0
Compare
c128fe0 to
ee4a67f
Compare
yaythomas
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#42 - pre-req for hitting it through web server.
Description of changes:
Updating the request handling for
SendDurableExecutionCallbackSuccessandSendDurableExecutionCallbackFailure. Both of these requests accept theirResultandErrorfields as@httpPayload, meaning they get serialized to a raw bytes body instead of JSON.I'm following the same convention as how we deserialize
.from_dict()for checkpoints where we pass the execution arn from the path to.from_dict()- except using the callback id.I tested it by using the AWS CLI and sending requests to the local server and ensuring that the requests were being deserialized properly.
Success:
Failure:
Dependencies
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.