feat: add validation for wait seconds less than 1#25
Merged
Conversation
yaythomas
approved these changes
Oct 8, 2025
yaythomas
requested changes
Oct 8, 2025
Contributor
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
type check failing for 3.11
Contributor
Author
I believe it fails for hatch issue - in the log the env failed to be created, which means the actually type check failed to start. |
yaythomas
requested changes
Oct 9, 2025
Contributor
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
please do a local rework of the commits, so feat commit is distinct to ci commit.
yaythomas
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.