fix(otel): classify uncaught invocation errors#581
Open
zhongkechen wants to merge 2 commits into
Open
Conversation
Report raw handler exceptions to instrumentation as RETRY while keeping the durable execution output FAILED. Mark retry invocation spans as OpenTelemetry errors and preserve FAILED telemetry for durable operation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RETRYwhile preserving the terminalFAILEDdurable execution responseRETRYinvocation spans with OpenTelemetryERRORstatusFAILEDRoot cause
The execution wrapper converts an uncaught handler exception into a
FAILEDdurable output beforePluginExecutoremits the invocation-end event. Instrumentation therefore receivedFAILED, and the OTel plugin also treated an explicitRETRYevent asUNSETrather thanERROR.This caused OTEL-19 to export an invocation span with
durable.invocation.status: FAILEDinstead of the requiredRETRYvalue.Testing
hatch run test:all(2980 passed, 2 skipped)hatch run types:checkhatch fmt --checkin the core packagehatch fmt --checkin the OTel packagehatch run python .github/scripts/lintcommit.pyThe hosted conformance fixture installs the SDK from
main, so OTEL-19 will consume this fix once the fixture points at this branch or the change lands.CI note
The hosted
child,map, andparallelconformance jobs fail on the initial run and a targeted rerun. They fail on custom-serdes output and cloud history assertions unrelated to invocation instrumentation. The immediately preceding unrelated PR run 30064400076 has the same three failing jobs. All other PR checks pass.