feat(otel): use semconv SERVICE_NAME for service.name - #597
Draft
SilanHe wants to merge 2 commits into
Draft
Conversation
Replace the raw "service.name" literal in provider._build_resource() with the stable OpenTelemetry semantic-conventions constant (opentelemetry.semconv.attributes.service_attributes.SERVICE_NAME), matching the Java SDK's ServiceAttributes.SERVICE_NAME. Declare opentelemetry-semantic-conventions explicitly (already a pinned transitive dep of opentelemetry-sdk). faas.*/cloud.* stay raw as they are incubating.
SilanHe
had a problem deploying
to
ai-pr-review-runtime
July 28, 2026 23:40 — with 
GitHub Actions
Failure
GitHub Actions
Failure
SilanHe
had a problem deploying
to
ai-pr-review-runtime
July 28, 2026 23:40 — with
GitHub Actions
Failure
GitHub Actions
Failure
SilanHe
marked this pull request as draft
July 28, 2026 23:46
SilanHe
had a problem deploying
to
ai-pr-review-runtime
July 28, 2026 23:46 — with
GitHub Actions
Failure
GitHub Actions
Failure
SilanHe
had a problem deploying
to
ai-pr-review-runtime
July 28, 2026 23:46 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Replace the raw "service.name" literal in provider._build_resource() with the stable OpenTelemetry semantic-conventions constant (opentelemetry.semconv.attributes.service_attributes.SERVICE_NAME), matching the Java SDK's ServiceAttributes.SERVICE_NAME. Declare opentelemetry-semantic-conventions explicitly (already a pinned transitive dep of opentelemetry-sdk). faas./cloud. stay raw as they are incubating.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.