fix: Replace hardcoded AWS credentials with AnonymousCredentialsProvi…#7148
Open
ford220102 wants to merge 1 commit into
Open
fix: Replace hardcoded AWS credentials with AnonymousCredentialsProvi…#7148ford220102 wants to merge 1 commit into
ford220102 wants to merge 1 commit into
Conversation
…der in benchmark
Security fix for java:S6263 - Long-term AWS access keys should not be used.
Replaced hardcoded dummy credentials ("test"/"test") with
AnonymousCredentialsProvider in V1CborRoundtripBenchmark.
The benchmark uses a local mock server and does not require
real AWS credentials. Using AnonymousCredentialsProvider makes
this intent explicit and avoids the security hotspot.
This change:
- Eliminates the security warning for hardcoded credentials
- Makes the code's intent clearer (no real AWS access needed)
- Is safe for benchmark code that never contacts real AWS services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…der in benchmark
Security fix for java:S6263 - Long-term AWS access keys should not be used.
Replaced hardcoded dummy credentials ("test"/"test") with AnonymousCredentialsProvider in V1CborRoundtripBenchmark.
The benchmark uses a local mock server and does not require real AWS credentials. Using AnonymousCredentialsProvider makes this intent explicit and avoids the security hotspot.
This change:
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License