[DynamoDB] Fix Key Expression building for renamable sort keys#4357
Open
irina-herciu wants to merge 1 commit intoaws:developmentfrom
Open
[DynamoDB] Fix Key Expression building for renamable sort keys#4357irina-herciu wants to merge 1 commit intoaws:developmentfrom
irina-herciu wants to merge 1 commit intoaws:developmentfrom
Conversation
Use the actual attribute name from PropertyStorage when building range-key expressions to support renamable range/sort keys. Updated ContextInternal to pass the PropertyStorage and use its AttributeName in expression attribute name mappings, and adjusted the helper signature accordingly. Added a unit test (TestRenamableAttributeEntity + ConvertQueryConditional_WithRenamableHashAndRangeAttributes_ReturnsValidSearch) and a mock DescribeTableResponse for that entity to validate the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the actual attribute name from PropertyStorage when building range-key expressions to support renamable range/sort keys.
Description
Motivation and Context
Testing
Unit test added
Breaking Changes Assessment
Screenshots (if appropriate)
Types of changes
Checklist
License