Skip to content

[DynamoDB] Fix Key Expression building for renamable sort keys#4357

Open
irina-herciu wants to merge 1 commit intoaws:developmentfrom
irina-herciu:bugfix/RenameableSortkey
Open

[DynamoDB] Fix Key Expression building for renamable sort keys#4357
irina-herciu wants to merge 1 commit intoaws:developmentfrom
irina-herciu:bugfix/RenameableSortkey

Conversation

@irina-herciu
Copy link
Contributor

@irina-herciu irina-herciu commented Mar 16, 2026

Use the actual attribute name from PropertyStorage when building range-key expressions to support renamable range/sort keys.

Description

Motivation and Context

Testing

Unit test added

Breaking Changes Assessment

  1. Identify all breaking changes including the following details:
    • What functionality was changed?
    • How will this impact customers?
    • Why does this need to be a breaking change and what are the most notable non-breaking alternatives?
    • Are best practices being followed?
    • How have you tested this breaking change?
  2. Has a senior/+ engineer been assigned to review this PR?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Use the actual attribute name from PropertyStorage when building range-key expressions to support renamable range/sort keys. Updated ContextInternal to pass the PropertyStorage and use its AttributeName in expression attribute name mappings, and adjusted the helper signature accordingly. Added a unit test (TestRenamableAttributeEntity + ConvertQueryConditional_WithRenamableHashAndRangeAttributes_ReturnsValidSearch) and a mock DescribeTableResponse for that entity to validate the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant