Conversation
generate_oss_compliance.sh installs PTable (an old prettytable fork) then uninstalls it, which corrupts the prettytable package directory already installed in the image by uv. This breaks pip-licenses and any other package depending on prettytable. Pass 'true' as the NO_UNINSTALL argument to skip the pip uninstall step. The upstream fix is tracked in CR-260711330 (Asimov-tools). Signed-off-by: Junpu Fan <junpu@amazon.com>
daa2217 to
2ce7969
Compare
Yadan-Wei
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
generate_oss_compliance.sh(downloaded from S3 at build time) installsPTable— an old prettytable fork that shares the sameprettytable/package directory — then uninstalls it after generating the compliance report. The uninstall removes__init__.pyandprettytable.pyfrom the shared directory, corrupting theprettytableinstall that was already placed there by uv.This causes all 3 Lambda GPU images to have a broken prettytable:
Which breaks
pip-licensesout of the box (it depends on prettytable).Fix
Pass
trueas theNO_UNINSTALLargument togenerate_oss_compliance.sh. This skips thepip uninstallstep after compliance generation, leaving the pre-installedprettytableintact.The
NO_UNINSTALLargument was added togenerate_oss_compliance.shin the upstreamAsimov-toolspackage, which also replacesPTablewithprettytablein the compliance script's requirements and updatespiplicenses.pyfor prettytable 3.x compatibility. The S3 zip has already been updated with those changes.Testing
Built and verified
base-py3andcupy-py3targets on a devbox —from prettytable import HRuleStyle, PrettyTable, RowTypesucceeds in both images after this fix.