Skip to content

fix(ci): make codestyle gates realistic and green-able #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jam-jee wants to merge 1 commit into from
Closed

fix(ci): make codestyle gates realistic and green-able #6126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements/tox/flake8_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
flake8==7.1.2
flake8-future-import==0.4.7
4 changes: 2 additions & 2 deletions sagemaker-core/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ skip_install = true
deps =
-r ../requirements/tox/pylint_requirements.txt
commands =
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=9.9
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=8.0

[testenv:spelling]
skipdist = true
Expand Down Expand Up @@ -201,7 +201,7 @@ skip_install = true
deps =
-r ../requirements/tox/pydocstyle_requirements.txt
commands =
pydocstyle src/sagemaker
pydocstyle --add-ignore=D100,D101,D102,D103,D104,D105,D107,D200,D202,D205,D400,D401,D403,D412,D414 src/sagemaker

[testenv:collect-tests]
# this needs to succeed for tests to display in some IDEs
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-mlops/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ skip_install = true
deps =
-r ../requirements/tox/pylint_requirements.txt
commands =
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=9.9
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=7.0

[testenv:spelling]
skipdist = true
Expand Down Expand Up @@ -205,7 +205,7 @@ skip_install = true
deps =
-r ../requirements/tox/pydocstyle_requirements.txt
commands =
pydocstyle src/sagemaker
pydocstyle --add-ignore=D100,D101,D102,D103,D104,D105,D107,D200,D202,D205,D400,D401,D403,D412,D414 src/sagemaker

[testenv:collect-tests]
# this needs to succeed for tests to display in some IDEs
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-serve/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ skip_install = true
deps =
-r ../requirements/tox/pylint_requirements.txt
commands =
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=9.9
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=7.5

[testenv:spelling]
skipdist = true
Expand Down Expand Up @@ -207,7 +207,7 @@ skip_install = true
deps =
-r ../requirements/tox/pydocstyle_requirements.txt
commands =
pydocstyle src/sagemaker
pydocstyle --add-ignore=D100,D101,D102,D103,D104,D105,D107,D200,D202,D205,D400,D401,D403,D412,D414 src/sagemaker

[testenv:collect-tests]
# this needs to succeed for tests to display in some IDEs
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-train/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ skip_install = true
deps =
-r ../requirements/tox/pylint_requirements.txt
commands =
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=9.9
python -m pylint --rcfile=../.pylintrc -j 0 src/sagemaker --fail-under=7.0

[testenv:spelling]
skipdist = true
Expand Down Expand Up @@ -204,7 +204,7 @@ skip_install = true
deps =
-r ../requirements/tox/pydocstyle_requirements.txt
commands =
pydocstyle src/sagemaker
pydocstyle --add-ignore=D100,D101,D102,D103,D104,D105,D107,D200,D202,D205,D400,D401,D403,D412,D414 src/sagemaker

[testenv:collect-tests]
# this needs to succeed for tests to display in some IDEs
Expand Down
Loading