feat(capacity-provider): add LoggingConfig for AWS::Serverless::CapacityProvider#3943
Open
vicheey wants to merge 2 commits into
Open
feat(capacity-provider): add LoggingConfig for AWS::Serverless::CapacityProvider#3943vicheey wants to merge 2 commits into
vicheey wants to merge 2 commits into
Conversation
SAM flattens CFN's TelemetryConfig.LoggingConfig to a top-level
LoggingConfig property, matching Function's existing pattern.
Generator wraps into {TelemetryConfig: {LoggingConfig: ...}} for CFN.
seshubaws
approved these changes
Jun 19, 2026
seshubaws
reviewed
Jun 19, 2026
licjun
reviewed
Jun 22, 2026
licjun
reviewed
Jun 22, 2026
licjun
reviewed
Jun 22, 2026
…tom class Updated cloudformation.schema.json to include TelemetryConfig definition. LoggingConfig now references AWS::Lambda::CapacityProvider.CapacityProviderLoggingConfig directly from the CFN schema, resolving schema naming ambiguity with Function's LoggingConfig.
licjun
approved these changes
Jun 22, 2026
Contributor
Author
|
DO NOT MERGE YET. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
N/A — Feature paritfor
AWS::Serverless::CapacityProviderTelemetryConfig support following AWS::Lambda::CapacityProvider CapacityProviderTelemetryConfig - AWS CloudFormationDescription of changes
Add
LoggingConfigproperty toAWS::Serverless::CapacityProvider. SAM flattens CFN'sTelemetryConfig.LoggingConfigwrapper to a top-levelLoggingConfigproperty, consistent with howAWS::Serverless::Functionalready exposesLoggingConfig.Customer experience:
CFN output:
Changes:
LoggingConfigPydantic model withPassThroughPropertyfields (supports!Ref)LoggingConfigproperty onSamCapacityProviderLoggingConfiginto{"TelemetryConfig": {"LoggingConfig": ...}}LoggingConfigadded to CapacityProvider globals (supports deep merge inheritance)TelemetryConfigproperty onLambdaCapacityProviderDescription of how you validated changes
make schema— regenerated JSON schemas from Pydantic modelsmake format— all files formattedpython3 -m pytest tests/translator/test_translator.py -k "capacity_provider_telemetry_config"— 3 passed (aws, aws-cn, aws-us-gov partitions)python3 -m pytest tests/schema/test_validate_schema.py -k "capacity_provider_telemetry"— 1 passed (schema validation of input template)ruff check— all checks passedmypy --strict— no issues in 177 filescfn-lint— cleanChecklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.