feat: h&s changes - #82
Draft
Ben754444 wants to merge 10 commits into
Draft
Conversation
Signed-off-by: Ben754444 <ben@benja.eu.org>
Signed-off-by: Ben754444 <ben@benja.eu.org>
Signed-off-by: Ben754444 <50147798+Ben754444@users.noreply.github.com>
helm chart:
|
helm chart:
|
Summary
TestsView All Tests
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe what work this pull request includes. There's no need to list line-by-line (the change list will do that);
instead just summarise each bit of functionality that's been added, edited or removed. Good code should be
self-documenting (aka, show what it's achieving) so focus on the explaining why you took the approach you did. We also
recommend highlighting any specific testing that may need to be performed on the staging server before it's deployed to
production.
There's no need to write an essay - we welcome bullet points over prose.
Ticket:
Checklist
Important
Make sure you follow these wherever possible; if you have then check it off, and if not then use a strikethrough (~)
to cross it off. This will help the reviewer identify any changes that may have been missed.
General
Principles