fix(announcement): auditor action in tags creation#9766
Open
ecurbelo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Elena Curbelo <ecurbelo@gmail.com>
backstage-service
added
the
workspace/announcements
Contributor
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the announcements backend auditor metadata for tag creation so that creating a tag is recorded as a create action (rather than update), aligning auditing with the actual operation.
Changes:
- Update the auditor event
meta.actionTypeforPOST /tagsfromAUDITOR_ACTION_UPDATEtoAUDITOR_ACTION_CREATE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| severityLevel: 'medium', | ||
| meta: { | ||
| actionType: AUDITOR_ACTION_UPDATE, | ||
| actionType: AUDITOR_ACTION_CREATE, |
Member
There was a problem hiding this comment.
Adding a test to prevent regression would also be nice.
Member
|
Hey @ecurbelo - thanks for the contribution! Can you please add the missing changeset for this and we can 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Announcement plugin
When a tag is created, the event emitted is "update" instead of "create".
✔️ Checklist
Signed-off-byline in the message. (more info)