feat(jaeger): add new frontend system support#9783
Open
RonitGandhi wants to merge 2 commits into
Open
Conversation
Closes backstage#7538 Signed-off-by: RonitGandhi <ronitgandhi.16@gmail.com>
Contributor
Changed Packages
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds New Frontend System (alpha) support for the Jaeger workspace plugin, enabling installation via the @backstage-community/plugin-jaeger/alpha export and registering the plugin’s API + entity content extension for feature discovery / configuration.
Changes:
- Introduces
src/alpha/*entrypoint withcreateFrontendPlugin, API blueprint, and entity content blueprint. - Updates package exports and dependencies to include
@backstage/frontend-plugin-apiand@backstage/core-compat-api. - Adds documentation and an API extractor alpha report, plus a changeset for the new capability.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspaces/jaeger/yarn.lock | Locks newly added Backstage frontend-system dependencies. |
| workspaces/jaeger/plugins/jaeger/src/alpha/plugin.ts | Defines the alpha frontend-system plugin and binds legacy route refs. |
| workspaces/jaeger/plugins/jaeger/src/alpha/plugin.test.ts | Adds a basic unit test for the alpha plugin export. |
| workspaces/jaeger/plugins/jaeger/src/alpha/index.ts | Exposes the alpha plugin as the default export for /alpha. |
| workspaces/jaeger/plugins/jaeger/src/alpha/entityContents.tsx | Adds the entity content (tab) extension using compat wrapper + route ref conversion. |
| workspaces/jaeger/plugins/jaeger/src/alpha/apis.ts | Adds the API extension wiring jaegerApiRef to JaegerClient. |
| workspaces/jaeger/plugins/jaeger/report-alpha.api.md | Adds generated alpha API report reflecting the new exports/extensions. |
| workspaces/jaeger/plugins/jaeger/README.md | Documents how to install/configure the plugin in the new frontend system. |
| workspaces/jaeger/plugins/jaeger/package.json | Adds ./alpha export + typesVersions and required dependencies. |
| workspaces/jaeger/.changeset/jaeger-new-frontend-system.md | Declares a minor release for the new alpha frontend-system support. |
…s map The exports map supersedes these fields; yarn fix --check flagged the package as out of sync. Signed-off-by: RonitGandhi <ronitgandhi.16@gmail.com>
Comment on lines
+29
to
+32
| extensions: [jaegerApi, jaegerEntityContent], | ||
| routes: convertLegacyRouteRefs({ | ||
| entityContent: rootRouteRef, | ||
| }), |
Comment on lines
+16
to
+22
| import { jaegerPlugin } from './plugin'; | ||
|
|
||
| describe('jaegerPlugin (alpha)', () => { | ||
| it('should export plugin', () => { | ||
| expect(jaegerPlugin).toBeDefined(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7538
Hey, I just made a Pull Request!
Adds new frontend system (alpha) support to the Jaeger plugin: registers the Jaeger API and the Traces entity content extension via a new
./alphaexport. Legacy exports are unchanged. Closes #7538.✔️ Checklist
Signed-off-byline in the message. (more info)