Skip to content

Migrate Stacktorm Plugin MUI to BUI#9784

Open
AmbrishRamachandiran wants to merge 1 commit into
backstage:mainfrom
AmbrishRamachandiran:stackstorm-mui-bui
Open

Migrate Stacktorm Plugin MUI to BUI#9784
AmbrishRamachandiran wants to merge 1 commit into
backstage:mainfrom
AmbrishRamachandiran:stackstorm-mui-bui

Conversation

@AmbrishRamachandiran

Copy link
Copy Markdown

Migrate Stacktorm Plugin MUI to BUI

Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
@backstage-goalie

Copy link
Copy Markdown
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-stackstorm workspaces/stackstorm/plugins/stackstorm patch v0.20.0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the Stackstorm plugin workspace UI from Material-UI (MUI v4) to Backstage UI (BUI), replacing component usage and styling and updating dependencies accordingly.

Changes:

  • Replaced MUI components/icons with @backstage/ui components and @remixicon/react icons.
  • Converted MUI makeStyles/withStyles usage to CSS modules and semantic HTML where appropriate.
  • Updated workspace dependencies/lockfile and added a changeset for the plugin.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
workspaces/stackstorm/yarn.lock Removes MUI deps; adds @backstage/ui and @remixicon/react resolutions.
workspaces/stackstorm/plugins/stackstorm/src/components/StackstormHome/StackstormHome.tsx Replaces MUI IconButton/LibraryBooks with BUI ButtonIcon + Remix icon.
workspaces/stackstorm/plugins/stackstorm/src/components/ExecutionsTable/ExecutionPanel.tsx Replaces MUI Card/Table/Typography with BUI Card/Button/Text and CSS-module-styled HTML table.
workspaces/stackstorm/plugins/stackstorm/src/components/ExecutionsTable/ExecutionPanel.module.css New CSS module for ExecutionPanel styling.
workspaces/stackstorm/plugins/stackstorm/src/components/ActionsList/ActionsList.tsx Replaces MUI list/collapse UI with HTML lists/buttons + BUI Text and CSS modules.
workspaces/stackstorm/plugins/stackstorm/src/components/ActionsList/ActionsList.module.css New CSS module for ActionsList styling.
workspaces/stackstorm/plugins/stackstorm/package.json Swaps MUI deps for @backstage/ui and @remixicon/react.
workspaces/stackstorm/.eslintrc.js Adds workspace override for react/forbid-elements.
workspaces/stackstorm/.changeset/witty-eels-kneel.md Adds a patch changeset documenting the migration.

Comment thread workspaces/stackstorm/.eslintrc.js
@AmbrishRamachandiran

Copy link
Copy Markdown
Author

@backstage/community-plugins-maintainers @hopehadfield please review

@awanlin awanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AmbrishRamachandiran, again as an Org member there's a high bar for your work. You've once again blown away the PR template. This helps both you and the reviewer. There's a specific ask for screenshots for UI changes which this PR is making. That would make reviewing this so much easier. Also, you keep pinging people when that happens automatically so we get 2 notifications. This has the opposite effect, it's more likely to disengage people then to get them to actually review your PR. Please keep this feedback in mind for future contributions. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants