[todo]: enable knip reports for workspace#9796
Open
SimoneBal wants to merge 1 commit into
Open
Conversation
Signed-off-by: SimoneBal <80442925+SimoneBal@users.noreply.github.com>
Contributor
Changed Packages
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Knip reports for the todo workspace and applies the resulting dependency cleanups so the workspace stays free of unused dependencies going forward (per #5992).
Changes:
- Enabled
"knipReports": truefor thetodoworkspace. - Removed unused dependencies from
@backstage-community/plugin-todoand@backstage-community/plugin-todo-backend. - Updated the workspace lockfile and added a changeset for the published packages.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workspaces/todo/bcp.json | Enables Knip reports in CI for the workspace. |
| workspaces/todo/plugins/todo/package.json | Removes unused @testing-library/dom devDependency. |
| workspaces/todo/plugins/todo/knip-report.md | Updates Knip report output (no remaining findings). |
| workspaces/todo/plugins/todo-backend/package.json | Removes unused @backstage/catalog-client and yn dependencies. |
| workspaces/todo/plugins/todo-backend/knip-report.md | Updates Knip report output (no remaining findings). |
| workspaces/todo/yarn.lock | Lockfile updates consistent with dependency removals. |
| workspaces/todo/.changeset/nice-rockets-prove.md | Changeset for the dependency cleanup in both published packages. |
Member
|
Hi @SimoneBal, can you try running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Issue #5992
Enabled
knipReportsand removed all unused dependencies for thetodoworkspace.✔️ Checklist
Signed-off-byline in the message. (more info)