Skip to content

Fix dynamic core CoreData initialization#9

Merged
bangerth merged 1 commit into
bangerth:core-datafrom
Francyrad:dynamic_core_coredata_initialization_fix
May 12, 2026
Merged

Fix dynamic core CoreData initialization#9
bangerth merged 1 commit into
bangerth:core-datafrom
Francyrad:dynamic_core_coredata_initialization_fix

Conversation

@Francyrad
Copy link
Copy Markdown

This is a small follow-up patch for geodynamics#6924.

It avoids copying CoreData from the CoreStatistics postprocessor on fresh runs, where the postprocessor data has not been initialized yet. In that path, core_data.H is initialized to 0.. On restart, the restored postprocessor CoreData is still used, and the current dt, H, and derived core quantities are recomputed before continuing.

@gassmoeller, does this match the initialization behavior you had in mind, and do you think it fully resolves the CoreData issue you pointed out?

Checks run locally:

  • Debug build: passed
  • No-unity debug build: passed
  • Dynamic core restart smoke test: passed
  • dynamic_core: passed
  • dynamic_core_fully_solid: passed
  • dynamic_core_fully_molten: only a local last-digit statistics diff, no SIGFPE

@bangerth bangerth marked this pull request as ready for review May 12, 2026 03:32
@bangerth bangerth merged commit c9f9ed9 into bangerth:core-data May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants