Fix dynamic core CoreData initialization#9
Merged
bangerth merged 1 commit intoMay 12, 2026
Merged
Conversation
bangerth
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up patch for geodynamics#6924.
It avoids copying
CoreDatafrom theCoreStatisticspostprocessor on fresh runs, where the postprocessor data has not been initialized yet. In that path,core_data.His initialized to0.. On restart, the restored postprocessorCoreDatais still used, and the currentdt,H, and derived core quantities are recomputed before continuing.@gassmoeller, does this match the initialization behavior you had in mind, and do you think it fully resolves the
CoreDataissue you pointed out?Checks run locally:
dynamic_core: passeddynamic_core_fully_solid: passeddynamic_core_fully_molten: only a local last-digit statistics diff, no SIGFPE