fix: correct output directory name for setup-bridge-partner-threshold target#762
Open
haileymarshall wants to merge 1 commit into
Open
fix: correct output directory name for setup-bridge-partner-threshold target#762haileymarshall wants to merge 1 commit into
haileymarshall wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732
What changed?
SET_BASE_BRIDGE_PARTNER_THRESHOLD_DIRon line 11 of the root Makefile produced directories named<network>/<date>-pause-bridge-base— a copy-paste ofPAUSE_BRIDGE_BASE_DIRon the line below. It now produces<network>/<date>-set-bridge-partner-threshold, consistent with the template name (template-set-bridge-partner-threshold) and the other setup targets.Why?
Running
make setup-bridge-partner-threshold network=<network>scaffolds the task under the wrong name, and — sincePAUSE_BRIDGE_BASE_DIRexpands to the identical path — a same-daymake setup-pause-bridge-basewould land in the same directory and mix the two tasks' files. The repo contains no*-set-bridge-partner-thresholdtask directory to date, so every use of this target has required manual renaming.How has it been tested?
Ran
make setup-bridge-partner-threshold network=sepoliaon this branch: it now createssepolia/<date>-set-bridge-partner-thresholdandsepolia/signatures/<date>-set-bridge-partner-thresholdas expected (test artifacts removed before commit).