Skip to content

fix: add HOST_IP support and strict LOG_LEVEL validation to reth entrypoint #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kewe63 wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −2
Open

fix: add HOST_IP support and strict LOG_LEVEL validation to reth entrypoint #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions reth/reth-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,28 @@ RETH_HISTORICAL_PROOFS="${RETH_HISTORICAL_PROOFS:-false}"
RETH_HISTORICAL_PROOFS_STORAGE_PATH="${RETH_HISTORICAL_PROOFS_STORAGE_PATH:-}"
LOG_LEVEL="${LOG_LEVEL:-info}"

case "$LOG_LEVEL" in
"error")
LOG_LEVEL="v"
;;
"warn")
LOG_LEVEL="vv"
;;
"info")
LOG_LEVEL="vvv"
;;
"debug")
LOG_LEVEL="vvvv"
;;
"trace")
LOG_LEVEL="vvvvv"
;;
*)
echo "Unknown log level: $LOG_LEVEL" >&2
exit 1
;;
esac

if [[ -z "${RETH_CHAIN:-}" ]]; then
echo "expected RETH_CHAIN to be set" 1>&2
exit 1
Expand Down Expand Up @@ -66,7 +88,17 @@ wait_for_pid() {
echo "Process $pid has exited."
}

# Add pruning for base
# Advertise public IP for better P2P peer discovery behind NAT
HOST_IP="${HOST_IP:-}"
NAT_ARG=""
if [ -n "$HOST_IP" ]; then
# Validate IPv4 format to prevent shell injection via malformed input
if [[ "$HOST_IP" =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
NAT_ARG="--nat=extip:$HOST_IP"
else
echo "WARNING: HOST_IP='$HOST_IP' is not a valid IPv4 address, ignoring" >&2
fi
fi
if [[ "${RETH_PRUNING_ARGS+x}" = x ]]; then
echo "Adding pruning arguments: $RETH_PRUNING_ARGS"
ADDITIONAL_ARGS="$ADDITIONAL_ARGS $RETH_PRUNING_ARGS"
Expand All @@ -82,7 +114,8 @@ if [[ "$RETH_HISTORICAL_PROOFS" == "true" && -n "$RETH_HISTORICAL_PROOFS_STORAGE
--http.addr=127.0.0.1 \
--http.port="$RPC_PORT" \
--http.api=eth \
--chain "$RETH_CHAIN" &
--chain "$RETH_CHAIN" \
$NAT_ARG &

PID=$!

Expand Down Expand Up @@ -153,6 +186,7 @@ exec "$BINARY" node \
--chain "$RETH_CHAIN" \
--rollup.sequencer-http="$RETH_SEQUENCER_HTTP" \
--rollup.disable-tx-pool-gossip \
$NAT_ARG \
--discovery.port="$DISCOVERY_PORT" \
--port="$P2P_PORT" \
$ADDITIONAL_ARGS