Skip to content

Scope templates --status flag to the list subcommand #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robzolkos merged 4 commits into from
Jul 2, 2026
+37 −17
Merged

Scope templates --status flag to the list subcommand #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2caca0
Scope templates --status flag to the list subcommand
robzolkos Jul 2, 2026
c88697f
Acknowledge --status surface removals and fix e2e test
robzolkos Jul 2, 2026
34359a1
Validate templates list --status value
robzolkos Jul 2, 2026
8140b48
Group templates --status entries into .surface-breaking FLAG section
robzolkos Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .surface
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11606,7 +11606,6 @@ FLAG basecamp templates --profile type=string
FLAG basecamp templates --project type=string
FLAG basecamp templates --quiet type=bool
FLAG basecamp templates --stats type=bool
FLAG basecamp templates --status type=string
FLAG basecamp templates --styled type=bool
FLAG basecamp templates --todolist type=string
FLAG basecamp templates --verbose type=count
Expand All @@ -11631,7 +11630,6 @@ FLAG basecamp templates construct --profile type=string
FLAG basecamp templates construct --project type=string
FLAG basecamp templates construct --quiet type=bool
FLAG basecamp templates construct --stats type=bool
FLAG basecamp templates construct --status type=string
FLAG basecamp templates construct --styled type=bool
FLAG basecamp templates construct --todolist type=string
FLAG basecamp templates construct --verbose type=count
Expand All @@ -11653,7 +11651,6 @@ FLAG basecamp templates construction --profile type=string
FLAG basecamp templates construction --project type=string
FLAG basecamp templates construction --quiet type=bool
FLAG basecamp templates construction --stats type=bool
FLAG basecamp templates construction --status type=string
FLAG basecamp templates construction --styled type=bool
FLAG basecamp templates construction --todolist type=string
FLAG basecamp templates construction --verbose type=count
Expand All @@ -11678,7 +11675,6 @@ FLAG basecamp templates create --profile type=string
FLAG basecamp templates create --project type=string
FLAG basecamp templates create --quiet type=bool
FLAG basecamp templates create --stats type=bool
FLAG basecamp templates create --status type=string
FLAG basecamp templates create --styled type=bool
FLAG basecamp templates create --todolist type=string
FLAG basecamp templates create --verbose type=count
Expand All @@ -11700,7 +11696,6 @@ FLAG basecamp templates delete --profile type=string
FLAG basecamp templates delete --project type=string
FLAG basecamp templates delete --quiet type=bool
FLAG basecamp templates delete --stats type=bool
FLAG basecamp templates delete --status type=string
FLAG basecamp templates delete --styled type=bool
FLAG basecamp templates delete --todolist type=string
FLAG basecamp templates delete --verbose type=count
Expand Down Expand Up @@ -11744,7 +11739,6 @@ FLAG basecamp templates show --profile type=string
FLAG basecamp templates show --project type=string
FLAG basecamp templates show --quiet type=bool
FLAG basecamp templates show --stats type=bool
FLAG basecamp templates show --status type=string
FLAG basecamp templates show --styled type=bool
FLAG basecamp templates show --todolist type=string
FLAG basecamp templates show --verbose type=count
Expand All @@ -11769,7 +11763,6 @@ FLAG basecamp templates update --profile type=string
FLAG basecamp templates update --project type=string
FLAG basecamp templates update --quiet type=bool
FLAG basecamp templates update --stats type=bool
FLAG basecamp templates update --status type=string
FLAG basecamp templates update --styled type=bool
FLAG basecamp templates update --todolist type=string
FLAG basecamp templates update --verbose type=count
Expand Down
7 changes: 7 additions & 0 deletions .surface-breaking
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,13 @@ FLAG basecamp reopen --styled type=bool
FLAG basecamp reopen --todolist type=string
FLAG basecamp reopen --verbose type=count
FLAG basecamp reopen --version type=bool
FLAG basecamp templates --status type=string
FLAG basecamp templates construct --status type=string
FLAG basecamp templates construction --status type=string
FLAG basecamp templates create --status type=string
FLAG basecamp templates delete --status type=string
FLAG basecamp templates show --status type=string
FLAG basecamp templates update --status type=string
FLAG basecamp tlgroup create --name type=string
FLAG basecamp tlgroup rename --name type=string
FLAG basecamp tlgroup update --name type=string
Expand Down
13 changes: 11 additions & 2 deletions e2e/templates.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,24 @@ load test_helper

# Flag parsing

@test "templates --status without value shows error" {
@test "templates list --status without value shows error" {
create_credentials
create_global_config '{"account_id": 99999}'

run basecamp templates --status
run basecamp templates list --status
assert_failure
assert_output_contains "--status requires a value"
}

@test "templates list --status with invalid value shows error" {
create_credentials
create_global_config '{"account_id": 99999}'

run basecamp templates list --status bogus
assert_failure
assert_output_contains "unknown --status value"
}


# Help

Expand Down
27 changes: 19 additions & 8 deletions internal/commands/templates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import (

// NewTemplatesCmd creates the templates command for managing project templates.
func NewTemplatesCmd() *cobra.Command {
var status string

cmd := &cobra.Command{
Use: "templates",
Short: "Manage project templates",
Expand All @@ -27,10 +25,8 @@ tools, and content.`,
Annotations: map[string]string{"agent_notes": "Construction from template is asynchronous — poll construction until status=completed to get the new project ID"},
}

cmd.PersistentFlags().StringVar(&status, "status", "active", "Filter: active, archived, trashed")

cmd.AddCommand(
newTemplatesListCmd(&status),
newTemplatesListCmd(),
newTemplatesShowCmd(),
newTemplatesCreateCmd(),
newTemplatesUpdateCmd(),
Expand All @@ -42,18 +38,33 @@ tools, and content.`,
return cmd
}

func newTemplatesListCmd(status *string) *cobra.Command {
return &cobra.Command{
func newTemplatesListCmd() *cobra.Command {
var status string

cmd := &cobra.Command{
Use: "list",
Short: "List templates",
Long: "List all project templates.",
RunE: func(cmd *cobra.Command, args []string) error {
return runTemplatesList(cmd, *status)
return runTemplatesList(cmd, status)
},
Comment thread
robzolkos marked this conversation as resolved.
}

cmd.Flags().StringVar(&status, "status", "active", "Filter: active, archived, trashed")

return cmd
}

func runTemplatesList(cmd *cobra.Command, status string) error {
// Validate before the value reaches the request URL — only the lifecycle
// filters the API understands are allowed.
switch status {
case "", "active", "archived", "trashed":
default:
return output.ErrUsage(
fmt.Sprintf("unknown --status value %q (expected active, archived, or trashed)", status))
}

app := appctx.FromContext(cmd.Context())

if err := ensureAccount(cmd, app); err != nil {
Expand Down