Log interrupted invocations to primary.log - #207
Merged
codeforester merged 1 commit intoAug 11, 2026
Merged
Conversation
codeforester
commented
Aug 11, 2026
| def _record_lifecycle_diagnostic(context: Context[Any, Any, Any], outcome: InvocationOutcome) -> None: | ||
| try: | ||
| context.log.debug("Unexpected command exception", exc_info=True) | ||
| if outcome.kind == "interrupted": |
Contributor
Author
There was a problem hiding this comment.
Would this work for other types of signals like SIGTERM or just for SIGINT?
Contributor
Author
There was a problem hiding this comment.
Good question. This change is specifically for Ctrl-C/SIGINT: base-cli normalizes KeyboardInterrupt to the interrupted outcome and logs it before lifecycle teardown. SIGTERM does not raise KeyboardInterrupt; by default it terminates the process without reliably running the logger or finalizer. Supporting SIGTERM would require explicit signal handlers, a defined exit code (typically 143), and platform-specific regression coverage, so I recommend keeping that as a separate follow-up rather than broadening #207.
codeforester
marked this pull request as ready for review
August 11, 2026 12:28
codeforester
deleted the
bug/206-20260811-persist-interrupt-diagnostics-in-the-primary-run-log
branch
August 11, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206