Reject control line breaks in test manifests - #1906
Merged
Merged
Conversation
codeforester
force-pushed
the
bug/1890-20260808-test-control-breaks
branch
from
August 8, 2026 20:34
4d293a0 to
03a3c0f
Compare
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject embedded NUL, LF, and CR characters in both
test.commandandtest.mise, matching the validation already applied to other manifest command surfaces.Issue
Fixes #1890
Validation
test.commandandtest.misewith NUL, LF, and CR valuesPYTHONPATH=/Users/rameshhp/work/base-cli/lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m unittest cli/python/base_setup/tests/test_manifest.py(52 passed)PYTHONPATH=/Users/rameshhp/work/base-cli/lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/pylint --rcfile=.pylintrc cli/python/base_setup/manifest.py cli/python/base_setup/tests/test_manifest.pyenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CLI_SOURCE_DIR=/Users/rameshhp/work/base-cli/lib/python BASE_CACHE_DIR=/private/tmp/base-v180-small-fixes ./bin/base-testDemo Impact
None.
Notes
.ai-context/is unchanged because this is a narrow manifest input-validation hardening, not a product-shape or workflow change.Checklist
<category>/<issue>-<YYYYMMDD>-<slug>, and the prefix matches the issue's single standard category label.Fixes #1890.