Suppress pip version notices in setup#914
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disable-pip-version-checkto Base-owned pip installs in the shell bootstrap path.Issue
Fixes #911
Validation
BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats -f "setup installs Base Python packages without pip self-version notices" cli/bash/commands/basectl/tests/setup.batsfailed before implementation because the flag was missing.PYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_artifacts.py -k "python_artifact_honors_project_venv_dir_override or reconcile_artifacts_batches_python_installs or retries_python_installs" -qfailed before implementation because the generated pip commands lacked the flag.BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats -f "setup installs Base Python packages without pip self-version notices" cli/bash/commands/basectl/tests/setup.batsPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_artifacts.py -k "python_artifact_honors_project_venv_dir_override or reconcile_artifacts_batches_python_installs or retries_python_installs" -qBASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/setup.batsPYTHONPATH=lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python/base_setup/tests/test_artifacts.py -qgit diff --checkenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash ./bin/base-testDemo Impact
None. Setup-output polish only.
Notes
Base does not auto-upgrade pip; it only suppresses pip self-version notices for Base-owned installs.