Revert "Use non interactive installations for background metadata refresh (#1397)"#1460
Open
AsciiWolf wants to merge 1 commit intobazaar-org:mainfrom
Open
Revert "Use non interactive installations for background metadata refresh (#1397)"#1460AsciiWolf wants to merge 1 commit intobazaar-org:mainfrom
AsciiWolf wants to merge 1 commit intobazaar-org:mainfrom
Conversation
AsciiWolf
changed the title
…resh (bazaar-org#1397)" This reverts commit 43765d5. This commit has unfortunately caused a regression in the Set Up Flathub dialog. Let's revert it until a proper fix is implemented. Fixes: bazaar-org#1419
AsciiWolf
force-pushed
the
noninteractive-revert
branch
from
20fab75 to
2133296
Compare
Collaborator
|
hmm looking into this, thanks for opening |
Contributor
Author
|
Hint: It's probably because of the polkit dialog not being shown when the non interactive installations code is used. It treats the Flathub system remote being added from the Set Up Flathub dialog as a non-interactive transaction for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 43765d5.
This commit has unfortunately caused a regression in the Set Up Flathub dialog.
Let's revert it until a proper fix is implemented.
Fixes: #1419