feat(cc): populate abi and platform settings on local py_cc_toolchain - #3990
Merged
rickeylev merged 3 commits intoAug 4, 2026
Merged
Conversation
The introduction of py_extension added abi_flags, abi_tag, platform_machine, and sys_platform to py_cc_toolchain. Local python runtime toolchains did not populate these fields, causing py_extension builds to fail when using local toolchains. Extract sys_platform, platform_machine, and abi_tag (from sysconfig SOABI) in get_local_runtime_info.py, pass them through local_runtime_repo.bzl, and set them on py_cc_toolchain in local_runtime_repo_setup.bzl.
rickeylev
force-pushed
the
update_py_cc_toolchain_runtime
branch
from
August 3, 2026 00:11
551fa1b to
1d96f18
Compare
rickeylev
enabled auto-merge
August 3, 2026 05:38
aignas
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cc): populate abi and platform settings on local py_cc_toolchain
The introduction of
py_extensionaddedabi_flags,abi_tag,platform_machine, andsys_platformtopy_cc_toolchain. Local Python runtime toolchains did not populate these fields, causingpy_extensionbuilds to fail when using local toolchains.Extract
sys_platform,platform_machine, andabi_tag(fromsysconfigSOABI) inget_local_runtime_info.py, pass them throughlocal_runtime_repo.bzl, and set them onpy_cc_toolchaininlocal_runtime_repo_setup.bzl.