Add AppNote0021 on integrity models#176
Merged
Merged
Conversation
j616
force-pushed
the
jamessa-integrity
branch
from
5bd4c8e to
29c4147
Compare
mglanville
reviewed
Feb 23, 2026
mglanville
reviewed
Feb 23, 2026
samdbmg
approved these changes
May 8, 2026
Member
samdbmg
left a comment
samdbmg
left a comment
There was a problem hiding this comment.
LGTM overall. Couple of suggestions and some nits inlined
|
|
||
| This option may be brittle. | ||
| Media in TAMS is commonly stored in a chunk form for flexibility and performance. | ||
| The process of chunking and re-combining media can be non-deterministic for many formats. |
Member
There was a problem hiding this comment.
Nit: Strictly is this process deterministic but chaotic? The same input will produce the same output (there's no noise in the process), but even an insignificant change to the ffmpeg (or similar) version will change it?
Contributor
Author
There was a problem hiding this comment.
If I'm not mistaken, I think encoding processes can use random data as part of their process. But I might be crossing a few wires in my memory there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR adds AppNote0021 which describes basic and advanced integrity models used in TAMS. The advanced model describes how checksums may be used for archived workflows.
Jira Issue (if relevant)
Jira URL: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5503
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.